Details

    • Attachments:
      0
    • Comments:
      17
    • Documentation Status:
      Needed

      Description

      Currently working on a mobile interface/theme for dspace and hope to share details within the next month with the dspace community.

        Attachments

          Issue Links

            Activity

            Hide
            helix84 Ivan Masár added a comment - - edited

            OK Elias, the theme requires some non-trivial changes before it's in shape for release. I won't have time to do that now, so if you want the theme included (the release team approved the exception), here's what you should fix by Friday (tomorrow):
            1) Hunt down all text the theme generates and use <i18n:text>
            2) Only add messages to messages.xml, don't change them. If you need to change any existing messages, do that in XSL (see above).
            3) replace yoursite.edu with a configuration variable (dspace.mobileUrl = http://mobile.$

            {dspace.hostname}

            ), retrieve this from dspace.cfg like this:

            <xsl:stylesheet ...
            xmlns:confman="org.dspace.core.ConfigurationManager"
            exclude-result-prefixes="... confman">

            <xsl:variable name="mobile-url" select="confman:getProperty('dspace.mobileUrl')"/>

            If you run into a problem you think you can't solve, don't hesitate to contact me.

            I didn't look at css, js, I don't expect any problem there. I didn't actually try setting up a mobile subdomain yet.

            Show
            helix84 Ivan Masár added a comment - - edited OK Elias, the theme requires some non-trivial changes before it's in shape for release. I won't have time to do that now, so if you want the theme included (the release team approved the exception), here's what you should fix by Friday (tomorrow): 1) Hunt down all text the theme generates and use <i18n:text> 2) Only add messages to messages.xml, don't change them. If you need to change any existing messages, do that in XSL (see above). 3) replace yoursite.edu with a configuration variable (dspace.mobileUrl = http://mobile.$ {dspace.hostname} ), retrieve this from dspace.cfg like this: <xsl:stylesheet ... xmlns:confman="org.dspace.core.ConfigurationManager" exclude-result-prefixes="... confman"> <xsl:variable name="mobile-url" select="confman:getProperty('dspace.mobileUrl')"/> If you run into a problem you think you can't solve, don't hesitate to contact me. I didn't look at css, js, I don't expect any problem there. I didn't actually try setting up a mobile subdomain yet.
            Hide
            helix84 Ivan Masár added a comment -

            Mobile theme is now in Git master: https://github.com/helix84/DSpace/commit/449c7f9dd9eb3636e7b39fae5e6d175fb3bb0c14

            Still waiting for minor bug fixes before closing this issue.

            Show
            helix84 Ivan Masár added a comment - Mobile theme is now in Git master: https://github.com/helix84/DSpace/commit/449c7f9dd9eb3636e7b39fae5e6d175fb3bb0c14 Still waiting for minor bug fixes before closing this issue.
            Hide
            helix84 Ivan Masár added a comment -

            The theme has been fixed and merged.

            One problem that remains to be fixed is to allow the theme to be accessible under the "/mobile" URL, not just the "mobile." domain.

            Show
            helix84 Ivan Masár added a comment - The theme has been fixed and merged. One problem that remains to be fixed is to allow the theme to be accessible under the "/mobile" URL, not just the "mobile." domain.
            Hide
            jrussell James Russell added a comment -

            Trying to use a pathname prefix, rather than a domain name, for the mobile theme proved somewhat problematical when I was experimenting with it. The issue was essentially that, when various DSpace code generated any link when viewing the mobile theme (for instance, all the assorted links that come up when browsing) there was no obvious way to get it to generate links that included the pathname prefix and referred back to the mobile theme. It's possible that there is a way around this, but nothing obvious came to mind, and in the interests of getting this out the door locally, I didn't look into it very hard. Using a new domain name seemed an obvious solution, because it would always be incorporated, explicitly or implicitly in any URL generated.

            Show
            jrussell James Russell added a comment - Trying to use a pathname prefix, rather than a domain name, for the mobile theme proved somewhat problematical when I was experimenting with it. The issue was essentially that, when various DSpace code generated any link when viewing the mobile theme (for instance, all the assorted links that come up when browsing) there was no obvious way to get it to generate links that included the pathname prefix and referred back to the mobile theme. It's possible that there is a way around this, but nothing obvious came to mind, and in the interests of getting this out the door locally, I didn't look into it very hard. Using a new domain name seemed an obvious solution, because it would always be incorporated, explicitly or implicitly in any URL generated.
            Hide
            helix84 Ivan Masár added a comment -

            Has been merged, so marking as fixed in 3.0.

            Opened a separate issue for the "/mobile" URL problem: DS-1375

            Show
            helix84 Ivan Masár added a comment - Has been merged, so marking as fixed in 3.0. Opened a separate issue for the "/mobile" URL problem: DS-1375

              People

              • Assignee:
                helix84 Ivan Masár
                Reporter:
                jon_scott Jonathon Scott
              • Votes:
                3 Vote for this issue
                Watchers:
                7 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - 16 weeks, 4 days
                  16w 4d
                  Remaining:
                  Remaining Estimate - 16 weeks, 4 days
                  16w 4d
                  Logged:
                  Time Spent - Not Specified
                  Not Specified