Uploaded image for project: 'DSpace'
  1. DSpace
  2. DS-1971

'bte-io' (v 0.9.2.3) dependency from EKT has an invalid SNAPSHOT dependency in its POM

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 4.0, 4.1
    • Fix Version/s: 4.2
    • Component/s: DSpace API
    • Labels:
      None
    • Attachments:
      0
    • Comments:
      8
    • Documentation Status:
      Needed

      Description

      For the Biblio Transformation Engine (BTE), DSpace includes dependencies on 'bte-io' and 'bte-core' versions 0.9.2.3 in it's main POM:

      https://github.com/DSpace/DSpace/blob/master/dspace-api/pom.xml#L439

      Unfortunately, it seems that 'bte-core' version 0.9.2.3 itself has a dependency on 'bte-core' version 0.9.2.3-SNAPSHOT in its POM in Maven Central:

      http://search.maven.org/remotecontent?filepath=gr/ekt/bte/bte-io/0.9.2.3/bte-io-0.9.2.3.pom

      Since the 0.9.2.3-SNAPSHOT version of 'bte-core' doesn't seem to exist in Maven Central (or in Sonatype's Maven repo), we are now seeing the following WARNING when building 'dspace-api':

      "[WARNING] The POM for gr.ekt.bte:bte-core:jar:0.9.2.3-SNAPSHOT is missing, no dependency information available"

      It looks like this 0.9.2.3-SNAPSHOT version is not available anywhere publicly.

      This POM problem is really just a WARNING reported by Maven. DSpace 4.x will still build properly with this missing dependency.

        Attachments

          Issue Links

            Activity

            Hide
            tdonohue Tim Donohue added a comment -

            Removed notes about errors from Bamboo. The Bamboo errors were caused by a slight misconfiguration of Bamboo, and not from this dependency warning.

            Show
            tdonohue Tim Donohue added a comment - Removed notes about errors from Bamboo. The Bamboo errors were caused by a slight misconfiguration of Bamboo, and not from this dependency warning.
            Hide
            mwood Mark H. Wood added a comment -

            From #dspace, 15-Apr-2014
            (14:25:24) hpottinger: Kevin Clarke points out to me (in another channel) that the Maven Enforcer plugin can be set up to prevent you from ever making dependencies on snapshots
            (14:33:34) mhwood: "This rule checks that the current project is not a snapshot." Not quite what we want?
            (14:36:01) mhwood: Or was that bannedDependencies, excluding ::*-SNAPSHOT? But we'd have to turn the rule off during development....
            (14:36:35) mhwood: I guess we could include org.dspace:dspace*:*-SNAPSHOT.
            (15:21:49) hpottinger: mhwood: thoughts about putting enforcer to use? perhaps a disabled by default config, which Bamboo and Travis CI can make use of?
            (15:23:39) mhwood: What exactly do we want to enforce? We could forbid any -SNAPSHOT artifacts other than our own, for example, with an exclude/include setup.
            (15:23:50) mhwood: We might not need to disable that one.
            (15:24:59) mhwood: I'm not sure I want the CIs to surprise us with rule failures that I don't see locally.
            (15:25:28) hpottinger: that's pretty much what happened today
            (15:26:34) mhwood: Exactly. If we'd had the inclusion/exclusion patterns I suggested above, we'd have seen this coming.

            Show
            mwood Mark H. Wood added a comment - From #dspace, 15-Apr-2014 (14:25:24) hpottinger: Kevin Clarke points out to me (in another channel) that the Maven Enforcer plugin can be set up to prevent you from ever making dependencies on snapshots (14:33:34) mhwood: "This rule checks that the current project is not a snapshot." Not quite what we want? (14:36:01) mhwood: Or was that bannedDependencies, excluding : :*-SNAPSHOT? But we'd have to turn the rule off during development.... (14:36:35) mhwood: I guess we could include org.dspace:dspace*:*-SNAPSHOT. (15:21:49) hpottinger: mhwood: thoughts about putting enforcer to use? perhaps a disabled by default config, which Bamboo and Travis CI can make use of? (15:23:39) mhwood: What exactly do we want to enforce? We could forbid any -SNAPSHOT artifacts other than our own, for example, with an exclude/include setup. (15:23:50) mhwood: We might not need to disable that one. (15:24:59) mhwood: I'm not sure I want the CIs to surprise us with rule failures that I don't see locally. (15:25:28) hpottinger: that's pretty much what happened today (15:26:34) mhwood: Exactly. If we'd had the inclusion/exclusion patterns I suggested above, we'd have seen this coming.
            Hide
            kutsurak Panagiotis Koutsourakis added a comment -

            Hello all,

            I am really sorry about this. I have already prepared a new version (0.9.2.4) that solves this issue, but before I release it in maven central have a question:

            Following the discussion here https://jira.duraspace.org/browse/DS-1857 version 0.9.2.3 was built using java 1.6, however according to this: https://jira.duraspace.org/browse/DS-1935 I see that DSpace is moving to use java 1.7. The question is: what should be the required compiler version for BTE v 0.9.2.4?

            Thank you,
            Panagiotis.

            Show
            kutsurak Panagiotis Koutsourakis added a comment - Hello all, I am really sorry about this. I have already prepared a new version (0.9.2.4) that solves this issue, but before I release it in maven central have a question: Following the discussion here https://jira.duraspace.org/browse/DS-1857 version 0.9.2.3 was built using java 1.6, however according to this: https://jira.duraspace.org/browse/DS-1935 I see that DSpace is moving to use java 1.7. The question is: what should be the required compiler version for BTE v 0.9.2.4? Thank you, Panagiotis.
            Hide
            mwood Mark H. Wood added a comment -

            Thank you for promptly addressing this issue.

            I think that DSpace should work with dependencies that are built by Java 1.6 or 1.7. You may have other dependents for which 1.7 would be too new. The conservative thing to do would be to go ahead and deploy your 1.6-built artifact to Central.

            Show
            mwood Mark H. Wood added a comment - Thank you for promptly addressing this issue. I think that DSpace should work with dependencies that are built by Java 1.6 or 1.7. You may have other dependents for which 1.7 would be too new. The conservative thing to do would be to go ahead and deploy your 1.6-built artifact to Central.
            Hide
            pottingerhj@umsystem.edu Hardy Pottinger (Inactive) added a comment -

            See also DS-1972 and DS-1921

            Show
            pottingerhj@umsystem.edu Hardy Pottinger (Inactive) added a comment - See also DS-1972 and DS-1921
            Hide
            kutsurak Panagiotis Koutsourakis added a comment -

            Great, thank you Mark. I will release v0.9.2.4 and then prepare a PR tomorrow or at the latest on Monday.

            Thanks,
            Panagiotis.

            Show
            kutsurak Panagiotis Koutsourakis added a comment - Great, thank you Mark. I will release v0.9.2.4 and then prepare a PR tomorrow or at the latest on Monday. Thanks, Panagiotis.
            Hide
            kutsurak Panagiotis Koutsourakis added a comment -

            The pull request is ready: https://github.com/DSpace/DSpace/pull/520

            Have a nice weekend.

            Show
            kutsurak Panagiotis Koutsourakis added a comment - The pull request is ready: https://github.com/DSpace/DSpace/pull/520 Have a nice weekend.
            Hide
            pottingerhj@umsystem.edu Hardy Pottinger (Inactive) added a comment -

            PR#520 has been merged to master, and cherry-picked to DSpace-4_x

            Show
            pottingerhj@umsystem.edu Hardy Pottinger (Inactive) added a comment - PR#520 has been merged to master, and cherry-picked to DSpace-4_x

              People

              • Assignee:
                hardyoyo Hardy Pottinger
                Reporter:
                tdonohue Tim Donohue
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: