Uploaded image for project: 'DSpace'
  1. DSpace
  2. DS-2200

Advanced search filters aren't shown in Mirage 2 if some UI string contains a single quote

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Volunteer Needed (View Workflow)
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 5.0
    • Fix Version/s: None
    • Component/s: XMLUI
    • Labels:
    • Attachments:
      0
    • Comments:
      0
    • Documentation Status:
      Not Required

      Description

      The fields that appear when clicking on "Show Advanced Filters" (in a search results page) don't show up if some of the strings xmlui.ArtifactBrowser.SimpleSearch.filter.* (messages.xml) contain a single quote (') character.

      The problem is the JavaScript in discovery.xsl [1] ends up with a syntax error:
      window.DSpace.i18n.discovery.filtertype.dateIssued='Data d'edició';

      In theory, the stringescapeutils:escapeEcmaScript() call should escape the quote, but it seem it's not happening for some reason.

      [1] https://github.com/DSpace/DSpace/blob/master/dspace-xmlui-mirage2/src/main/webapp/xsl/aspect/discovery/discovery.xsl#L391

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              alexm Àlex Magaz Graça
            • Votes:
              1 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated: