Uploaded image for project: 'DSpace'
  1. DSpace
  2. DS-2395

ItemDAO* still uses bundle.name (now moved to metadatavalue)

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 5.0
    • Fix Version/s: 5.0
    • Component/s: DSpace API
    • Labels:
      None
    • Attachments:
      0
    • Comments:
      5
    • Documentation Status:
      Needed

      Description

      There are still SQL queries using bundle.name in the ItemDAOPostgres and ItemDAOOracle class. bundle.name has been moved to metadatavalue WHERE resource_type_id=1 AND metadata_field_id=(SELECT metadata_field_id FROM metadatafieldregistry WHERE metadata_schema_id=(SELECT metadata_schema_id FROM metadataschemaregistry WHERE short_id='dc') AND element='title' AND qualifier IS NULL);

      As a "metadata for all" side note - with future move to DCTERMS in mind, is it wise to hardcode WHERE short_id='dc'? Or should we have a global constant for the default metadata namespace for non-item objects?

      As this SQL should trigger a SQLException, it might be worth investigating how this was overlooked.

      https://github.com/DSpace/DSpace/blob/dspace-5.0-rc3/dspace-api/src/main/java/org/dspace/content/dao/ItemDAOPostgres.java
      https://github.com/DSpace/DSpace/blob/dspace-5.0-rc3/dspace-api/src/main/java/org/dspace/content/dao/ItemDAOOracle.java

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              mwood Mark H. Wood
              Reporter:
              helix84 Ivan Masár
              Reviewer:
              Ivan Masár
              Votes:
              1 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: