Uploaded image for project: 'DSpace'
  1. DSpace
  2. DS-2562

Incorrect action check in HandleAuthorizedMatcher

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 5.1
    • Fix Version/s: 5.2
    • Component/s: XMLUI
    • Labels:
      None
    • Attachments:
      0
    • Comments:
      2
    • Documentation Status:
      Not Required

      Description

      In the HandleAuthorizedMatcher the check to see whether an action is a valid action is currently done by trying to assign an integer to the index of the action string in the Constants.actionText array. However, the check is written in an if statement where null is returned if the action integer > 0 or >= Constants.actionText.length. Considering an invalid action is currently defined as -1, only invalid actions and the READ action (index of 0) will be compared correctly. The > 0 comparison needs to be < 0.

        Attachments

          Activity

            People

            • Assignee:
              tdonohue Tim Donohue
              Reporter:
              timatmire Tim [@mire]
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: