Uploaded image for project: 'DSpace'
  1. DSpace
  2. DS-2601

One illegal recipient for workflow emails breaks emails to all members of the group

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Accepted / Claimed (View Workflow)
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: 3.0, 3.1, 3.2, 4.1, 4.2, 4.3, 5.0, 5.1, 5.2
    • Fix Version/s: None
    • Component/s: None
    • Attachments:
      0
    • Comments:
      2
    • Documentation Status:
      Not Required

      Description

      If you have a workflow group that has a member with a faulty email address, it could prevent ANY member of the workflow group to receive emails.

      You will see something like this in the logs:

      2015-06-04 12:37:13,326 WARN org.dspace.workflow.WorkflowManager @ XXXX@XXXX:session_id=3F7C1704BE8F2DB31447FCC8EFF3DD17:notifyGroupofTask:cannot email user group_id=6 workflow_item_id=14\colon; Invalid Addresses

      How to solve:
      The type of messaging exceptions that appears here should really be in the for loop which iterates over the group members, and not after it:

      https://github.com/DSpace/DSpace/blob/master/dspace-api/src/main/java/org/dspace/workflow/WorkflowManager.java#L1005

      Also, the stacktrace of the exception should be logged.

      This only applies to the STANDARD DSpace workflow and not with the XML Workflow/Configurable workflow.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                schweer Andrea Schweer
                Reporter:
                bram Bram Luyten (Atmire)
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated: