The new Healthcheck feature is not functioning properly.
There's a few issues that are minor (which I'll note the resolution to), but also a few that are currently throwing errors (at least on demo).
Currently, running ./dspace health -e [email] fails because of two easy to fix issues:
- The healthcheck email template expects to be filtered by Ant. Email templates are no longer filtered, so we need to get rid of the dspace.name and dspace.url placeholders in this email template: https://github.com/DSpace/DSpace/blob/master/dspace/config/emails/healthcheck
- The healthcheck.cfg file is NOT being loaded by dspace.cfg in this section: https://github.com/DSpace/DSpace/blob/master/dspace/config/dspace.cfg#L2001
Once those two issues are fixed, it 'mostly works'... but the "General Information" section has a NullPointerException, and the Embargo section has an IllegalArgumentException (at least on demo.dspace.org).
Unfortunately, I don't have development time today/tomorrow to generate a PR, so I wanted to get this logged as a ticket. Hopefully someone else has time to help resolve it.