Uploaded image for project: 'DSpace'
  1. DSpace
  2. DS-3477

Mirage item-view.xsl altmetrics config is not read due to deprecated scope reference

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 6.0
    • Fix Version/s: 6.1
    • Component/s: XMLUI
    • Labels:
      None
    • Attachments:
      0
    • Comments:
      1
    • Documentation Status:
      Not Required

      Description

      item-view.xsl tries to read configuration properties from the [dspace]/config/modules/altmetrics.cfg file to embed altmetrics javascript, but is incorrectly including an extra scope of "altmetrics", which is not (or no longer?) needed, and causes the lookups to fail in DSpace 6.x and perhaps 5.x (as yet untested).
      This causes the javascript/badge/etc to be skipped since the 'enabled' test always fails, as well as the other config lookups.

      Removing the reference to "altmetrics" resolves the issue and is consistent with other ways confman:getProperty is used in XMLUI templates.

      In brief:

      confman:getProperty("altmetrics", "altmetric.enabled")

      should be

      confman:getProperty("altmetric.enabled")

      Pull request at: https://github.com/DSpace/DSpace/pull/1637

        Attachments

          Activity

            People

            • Assignee:
              kshepherd Kim Shepherd
              Reporter:
              kshepherd Kim Shepherd
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: