Uploaded image for project: 'DSpace'
  1. DSpace
  2. DS-3522

Submission Resource Policy not correctly removed during XMLWorkflow

    Details

    • Type: Bug
    • Status: Code Review Needed (View Workflow)
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 5.5, 5.6
    • Fix Version/s: 6.3
    • Component/s: DSpace API
    • Labels:
      None
    • Environment:
      macOS Sierra
    • Attachments:
      0
    • Comments:
      6

      Description

      While testing for a client with XML Workflow, it was noticed that an extra policy was being retained even before inheriting from the parent collection.

      During the doProcessing method for CompleteStep, the XMLWorkflowManager is started. During this process, the current user's policies are removed. Directly after, a new READ policy is added for that user with no Resource Policy type.

      Then, during InstallItem.finishItem, the Item is supposed to inherit the parent Collection's policies. However, because the READ policy has no Resource Policy type, Item.inheritCollectionDefaultPolicies (and subsequently Item.adjustItemPolicies) cannot properly remove the READ policy, leaving it behind.

      While this doesn't seem to affect behavior, it leaves behind needless policies which may confuse users.

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              kingkrimmson Chris Herron (Atmire)
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated: