Uploaded image for project: 'DSpace'
  1. DSpace
  2. DS-3674

PluginServiceTest.java does not have a provided testing config and thus tests a live config

    Details

    • Attachments:
      0
    • Comments:
      3
    • Documentation Status:
      Needed

      Description

      PluginServiceTest.java contains a set of tests that look for the presence of a few default "SelfNamed" Plugins, and since the testing configuration does not include a copy of input-forms.xml, the live version of input-forms.xml is tested. Which means the default common-types configuration in place in input-forms.xml is required in order to pass unit tests, which is probably not the intention of the test. A simple fix for this is to copy the default input-forms.xml to the dspace-api/src/test/data/dspaceFolder/config folder, thus ensuring the test has the data it expects to have, and the local configuration can be whatever we need it to be. This is a very simple thing to do, I'll make a PR for this change later this morning.

        Attachments

          Activity

            People

            • Assignee:
              hardyoyo Hardy Pottinger
              Reporter:
              hardyoyo Hardy Pottinger
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: