Uploaded image for project: 'DSpace'
  1. DSpace
  2. DS-3885

CommunityServiceImpl should clear modification flag on update

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 6.2
    • Fix Version/s: 6.4, 7.0
    • Component/s: DSpace API
    • Labels:
      None
    • Attachments:
      0
    • Comments:
      5
    • Documentation Status:
      Not Required

      Description

      While reviewing the CommunityServiceImpl code, I discovered that the update method is setting the modified flag (which is already set), instead of clearing it.

      See: https://github.com/mohideen/drum/blob/dspace-6.2/dspace-api/src/main/java/org/dspace/content/CommunityServiceImpl.java#L265

      We can see the CollectionServiceImpl correctly clearing the modified flag here: https://github.com/mohideen/drum/blob/dspace-6.2/dspace-api/src/main/java/org/dspace/content/CollectionServiceImpl.java#L647

       

      I have not personally experienced any issues due to this, but I guess it would have some unwanted implications.

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              mohideen Mohamed Mohideen Abdul Rasheed
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: