Uploaded image for project: 'DSpace'
  1. DSpace
  2. DS-4129

Remove obsolete/unnecessary OAI HarvestConsumer ("harvester" consumer) class

    Details

    • Attachments:
      0
    • Comments:
      2
    • Documentation Status:
      Needed

      Description

      In DSpace 6.0, the OAI-PMH Harvester functionality was significantly refactored in DS-3086 (PR: https://github.com/DSpace/DSpace/pull/1326)

      This code refactor also involved removing the "harvester" consumer configurations from dspace.cfg:

      event.consumer.harvester.class = org.dspace.harvest.HarvestConsumer
      event.consumer.harvester.filters = Item+Delete

      However, the PR & ticket neglected to remove the actual "HarvestConsumer" class from our codebase. This class is no longer needed, as it was only used to clean up after Item deletions (see above configuration). This cleanup is now much more explicit in the codebase itself.

      `Item.delete()` now explicitly calls `HarvestedItemService.delete()`: https://github.com/DSpace/DSpace/blob/master/dspace-api/src/main/java/org/dspace/content/ItemServiceImpl.java#L663-L668

      `Collection.delete()` now explicitly calls `HarvestedCollectionService.delete()`:
      https://github.com/DSpace/DSpace/blob/master/dspace-api/src/main/java/org/dspace/content/CollectionServiceImpl.java#L686-L690

      So, the old "HarvestConsumer" class is no longer necessary in DSpace 6.x (or above) and should be removed from our codebase and Official Documentation.

       

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                tdonohue Tim Donohue
                Reporter:
                tdonohue Tim Donohue
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: