Uploaded image for project: 'DSpace'
  1. DSpace
  2. DS-546

XMLUI 'Notice's are always added by the Administrative aspect even if the content was generated by another aspect.

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.5.2
    • Fix Version/s: 1.7.0
    • Component/s: XMLUI
    • Labels:
      None
    • Attachments:
      0
    • Comments:
      5
    • Documentation Status:
      Not Required

      Description

      Not sure if this qualifies as a bug. I am looking for some comments or advice...

      The XMLUI has a utility class org.dspace.app.xmlui.aspect.general.NoticeTransformer that facilitates adding a simple 'Notice' div to a page. Unfortunately this transformer is always invoked by the Administrative sitemap...

      <map:match type="WildcardParameterMatcher" pattern="true">
      <map:parameter name="parameter-name" value="notice"/>
      <map:parameter name="notice" value="

      {flow-attribute:notice}

      "/>
      <map:transform type="notice">

      This prevents the reuse of NoticeTransformer in other aspects and breaks the notion of each aspect being independent. Either the class should be moved out of the 'general' package and into an 'administrative' package, or, the class should only be invoked in the Administrative sitemap if the content was generated in the Administrative aspect. This could be achieved by adding a match against the url ...

      <map:match pattern="admin/**">

      This would be my preferred option but it might break any customisations that have been done relying on the fact that the Admin aspect would always add any Notices.

        Attachments

          Activity

            People

            • Assignee:
              robintaylor Robin Taylor
              Reporter:
              robintaylor Robin Taylor
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: