[DS-768] All XMLUI Error Pages respond with 200 OK, instead of 404 Not Found - DuraSpace JIRA

Details

Type: Bug
Status: Closed (View Workflow)
Priority: Major
Resolution: Fixed
Affects Version/s: 1.6.0, 1.6.1, 1.6.2, 1.7.0, 1.8.0
Fix Version/s: 1.8.0
Component/s: XMLUI
Labels:
None

Attachments:
6
Comments:
58

Description

In DSpace 1.7.0 RC1, the XMLUI "Page Not Found" page responds with a 200 OK, rather than the necessary 404 Not Found error.

For example:
http://demo.dspace.org/xmlui/NOTAVALIDPATH

I believe this used to function properly in 1.6.x, but it seems to be broken now.

Obviously, we want this to return a 404 Not Found, in order to ensure that search engines do not index "Page Not Found" responses.

Furthermore, it has been discovered that all other XMLUI Error pages (Cocoon Errors or Invalid Continuation errors) also respond with 200 OK. In addition, it seems this affects all 1.6.x versions of DSpace, as the same responses can be found on http://dspace.mit.edu (currently running 1.6.0 with patches), and http://researchspace.auckland.ac.nz (currently running 1.6.2 with patches).

Options
- Sort By Name
- Sort By Date
- Ascending
- Descending
- Download All

Attachments

[DS-768]_add_ProcessingException_to_transformers

04/Oct/11 4:44 AM

6 kB

Kim Shepherd
[DS-768]_dspace-cocoon-servlet-service-impl-1_0_2.patch

13/Jul/11 2:24 AM

13 kB

Kim Shepherd
add_ResourceNotFoundException_to_xmlui_transformers.patch

17/Aug/11 4:11 AM

5 kB

Kim Shepherd
Hide
dspace-cocoon-servlet-service-impl-1.0.2.jar

13/Jul/11 2:21 AM

84 kB

Kim Shepherd
META-INF/MANIFEST.MF 0.1 kB

META-INF/.../cocoon-callstack-environment.xml 3 kB

META-INF/.../cocoon-servlet-service-block-servlet-map.xml 2 kB

META-INF/.../cocoon-servletservice-context.xml 2 kB

META-INF/LICENSE.txt 11 kB

META-INF/NOTICE.txt 0.2 kB

META-INF/spring.handlers 0.9 kB

META-INF/spring.schemas 0.9 kB

org/apache/.../callstack/CallFrame.class 2 kB

org/apache/.../callstack/CallScope.class 2 kB

org/apache/.../callstack/CallStack.class 2 kB

org/apache/.../CallFrameHelper.class 2 kB

org/.../HttpServletRequestFactoryBean.class 1 kB

org/.../HttpServletResponseFactoryBean.class 1 kB

org/.../ServletContextFactoryBean.class 1 kB

org/apache/.../ServletScope.class 3 kB

org/.../AbsoluteServletConnection.class 4 kB

org/apache/.../Absolutizable.class 0.3 kB

org/.../AbstractServletConnection$NoServletContextAvailableException.class 0.6 kB

org/.../AbstractServletConnection.class 4 kB

org/apache/.../CallStackHelper.class 3 kB

org/apache/.../DispatcherServlet.class 5 kB

org/.../DynamicProxyRequestHandler.class 3 kB

org/.../HttpServletResponseBufferingWrapper$ForwardingOrLimitingServletOutputStream.class 3 kB

org/.../HttpServletResponseBufferingWrapper$LimitingServletOutputStream.class 2 kB

org/.../HttpServletResponseBufferingWrapper.class 6 kB

org/apache/.../Mountable.class 0.2 kB

org/.../RelativeServletConnection.class 4 kB

org/apache/.../schema/cocoon-servlet-1.0.xsd 4 kB

org/apache/.../ServletConnection.class 0.6 kB

Showing 30 of 60 items Download Zip
Show

dspace-cocoon-servlet-service-impl-1.0.2.jar

13/Jul/11 2:21 AM

84 kB

Kim Shepherd

Screen shot 2011-08-17 at 2.20.40 PM.png

74 kB

17/Aug/11 2:26 AM
Screenshot-Resource not found-Mozilla Firefox.png

119 kB

05/Oct/11 11:20 AM

Issue Links

is related to

DS-253 NullPointerException in HttpServletResponseBufferingWrapper (Cocoon bug?)

DS-1347 Using an invalid identifier leads to an exception rather than the user-friendly invalid identifier page

DS-1384 Very heavy error pages

DS-754 Revisit Browse-By Responses for DSpace 1.8.0

DS-1596 Page not found look and feel

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

Tim Donohue added a comment - 23/Nov/10 8:00 PM

This problem also seems to extend to all error screens in 1.7.0 XMLUI. Currently the "Invalid Continuation" error screen (e.g. see ~~DS-613~~), and general Cocoon Error screens both also return 200 OK instead of 404 Not Found.

I'm not sure what could have changed, as the error handling at the bottom of the main sitemap.xmap, specifically says to return a 404 response (see the 'status-code' value below):

http://scm.dspace.org/svn/repo/dspace/trunk/dspace-xmlui/dspace-xmlui-webapp/src/main/webapp/sitemap.xmap

                               <map:when test="invalid-continuation">
                                        <map:generate type="exception"/>
                                        <map:transform src="exception2html.xslt">
                                                <map:parameter name="contextPath" value="{request:contextPath}"/>
                                                <map:parameter name="pageTitle" value="Invalid Continuation"/>
                                        </map:transform>
                                        <map:serialize type="xhtml" status-code="404"/>
                                </map:when>

If anyone has an ideas on this, I'd appreciate suggestions. I'll keep digging around a bit to see what I can figure out.

Show

Tim Donohue added a comment - 23/Nov/10 8:00 PM This problem also seems to extend to all error screens in 1.7.0 XMLUI. Currently the "Invalid Continuation" error screen (e.g. see DS-613 ), and general Cocoon Error screens both also return 200 OK instead of 404 Not Found. I'm not sure what could have changed, as the error handling at the bottom of the main sitemap.xmap, specifically says to return a 404 response (see the 'status-code' value below): http://scm.dspace.org/svn/repo/dspace/trunk/dspace-xmlui/dspace-xmlui-webapp/src/main/webapp/sitemap.xmap <map:when test="invalid-continuation"> <map:generate type="exception"/> <map:transform src="exception2html.xslt"> <map:parameter name="contextPath" value="{request:contextPath}"/> <map:parameter name="pageTitle" value="Invalid Continuation"/> </map:transform> <map:serialize type="xhtml" status-code="404"/> </map:when> If anyone has an ideas on this, I'd appreciate suggestions. I'll keep digging around a bit to see what I can figure out.

52 older comments

Hide

Permalink

Tim Donohue added a comment - 11/Oct/11 9:49 PM

To slightly restate what I just "implied" above with my last statement. I think if we pull down the latest versions (HEAD) of HttpServletResponseBufferingWrapper.java & HttpServletResponseBufferingWrapperTestCase.java & commit both to our DSpace SCM, then that will resolve our issues.

http://svn.apache.org/viewvc/cocoon/trunk/subprojects/cocoon-servlet-service/cocoon-servlet-service-impl/src/main/java/org/apache/cocoon/servletservice/HttpServletResponseBufferingWrapper.java

http://svn.apache.org/viewvc/cocoon/trunk/subprojects/cocoon-servlet-service/cocoon-servlet-service-impl/src/test/java/org/apache/cocoon/servletservice/HttpServletResponseBufferingWrapperTestCase.java

(famous last words) ;)

Show

Tim Donohue added a comment - 11/Oct/11 9:49 PM To slightly restate what I just "implied" above with my last statement. I think if we pull down the latest versions (HEAD) of HttpServletResponseBufferingWrapper.java & HttpServletResponseBufferingWrapperTestCase.java & commit both to our DSpace SCM, then that will resolve our issues. http://svn.apache.org/viewvc/cocoon/trunk/subprojects/cocoon-servlet-service/cocoon-servlet-service-impl/src/main/java/org/apache/cocoon/servletservice/HttpServletResponseBufferingWrapper.java http://svn.apache.org/viewvc/cocoon/trunk/subprojects/cocoon-servlet-service/cocoon-servlet-service-impl/src/test/java/org/apache/cocoon/servletservice/HttpServletResponseBufferingWrapperTestCase.java (famous last words) ;)

Hide

Permalink

Kim Shepherd added a comment - 12/Oct/11 3:28 AM

Good call Tim, I've tested that out and it all seems fine here, so I've committed the changes back to source. Nearly the end of the day here so after dinner I'll have a go at a sonatype release.

Show

Kim Shepherd added a comment - 12/Oct/11 3:28 AM Good call Tim, I've tested that out and it all seems fine here, so I've committed the changes back to source. Nearly the end of the day here so after dinner I'll have a go at a sonatype release.

Hide

Permalink

Tim Donohue added a comment - 12/Oct/11 3:00 PM

I re-tested since Kim re-patched the above classes (see r6800 in DSpace SCM). Everything now seems to be working perfectly. I get a 404 when accessing any invalid path (and continue to get a 404 if I keep accessing that same path over and over).

I think the only things left to do are:
* Release a 1.0.3 version of dspace-cocoon-servlet-service-impl to Maven Central
* Once propagated to Maven Central, change the dependency in [Trunk]/dspace-xmlui/dspace-xmlui-wing/pom.xml to point at version 1.0.3 of dspace-cocoon-servlet-service-impl

Show

Tim Donohue added a comment - 12/Oct/11 3:00 PM I re-tested since Kim re-patched the above classes (see r6800 in DSpace SCM). Everything now seems to be working perfectly. I get a 404 when accessing any invalid path (and continue to get a 404 if I keep accessing that same path over and over). I think the only things left to do are: * Release a 1.0.3 version of dspace-cocoon-servlet-service-impl to Maven Central * Once propagated to Maven Central, change the dependency in [Trunk]/dspace-xmlui/dspace-xmlui-wing/pom.xml to point at version 1.0.3 of dspace-cocoon-servlet-service-impl

Hide

Permalink

Kim Shepherd added a comment - 12/Oct/11 9:03 PM

Version 1.0.3 of dspace-cocoon-servlet-service-impl released to sonatype

Show

Kim Shepherd added a comment - 12/Oct/11 9:03 PM Version 1.0.3 of dspace-cocoon-servlet-service-impl released to sonatype

Hide

Permalink

Robin Taylor added a comment - 13/Oct/11 1:17 PM

dspace-xmlui-wing/pom.xml updated to pick up version 1.0.3 of dspace-cocoon-servlet-service-impl. Committed to trunk revision 6811.

Cheers, Robin.

Show

Robin Taylor added a comment - 13/Oct/11 1:17 PM dspace-xmlui-wing/pom.xml updated to pick up version 1.0.3 of dspace-cocoon-servlet-service-impl. Committed to trunk revision 6811. Cheers, Robin.

People

Assignee:

Kim Shepherd

Reporter:

Tim Donohue

Votes:

0 Vote for this issue

Watchers:

1 Start watching this issue

Dates

Created:

23/Nov/10 7:08 PM

Updated:

08/Aug/13 4:10 PM

Resolved:

12/Oct/11 9:03 PM

Agile

View on Board