Details
-
Type:
Bug
-
Status: Closed (View Workflow)
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: 1.6.0, 1.6.1, 1.6.2, 1.7.0, 1.8.0
-
Fix Version/s: 1.8.0
-
Component/s: XMLUI
-
Labels:None
-
Attachments:
-
Comments:58
-
Documentation Status:Not Required
Description
In DSpace 1.7.0 RC1, the XMLUI "Page Not Found" page responds with a 200 OK, rather than the necessary 404 Not Found error.
For example:
http://demo.dspace.org/xmlui/NOTAVALIDPATH
I believe this used to function properly in 1.6.x, but it seems to be broken now.
Obviously, we want this to return a 404 Not Found, in order to ensure that search engines do not index "Page Not Found" responses.
Furthermore, it has been discovered that all other XMLUI Error pages (Cocoon Errors or Invalid Continuation errors) also respond with 200 OK. In addition, it seems this affects all 1.6.x versions of DSpace, as the same responses can be found on http://dspace.mit.edu (currently running 1.6.0 with patches), and http://researchspace.auckland.ac.nz (currently running 1.6.2 with patches).
Attachments
Issue Links
- is related to
-
-
- Closed
-
-
-
- Closed
-
-
-
- Closed
-
-
DS-754 Revisit Browse-By Responses for DSpace 1.8.0
-
- Closed
-
-
DS-1596 Page not found look and feel
-
- Closed
-
Activity
To slightly restate what I just "implied" above with my last statement. I think if we pull down the latest versions (HEAD) of HttpServletResponseBufferingWrapper.java & HttpServletResponseBufferingWrapperTestCase.java & commit both to our DSpace SCM, then that will resolve our issues.
(famous last words) 
Good call Tim, I've tested that out and it all seems fine here, so I've committed the changes back to source. Nearly the end of the day here so after dinner I'll have a go at a sonatype release.
I re-tested since Kim re-patched the above classes (see r6800 in DSpace SCM). Everything now seems to be working perfectly. I get a 404 when accessing any invalid path (and continue to get a 404 if I keep accessing that same path over and over).
I think the only things left to do are:
- Release a 1.0.3 version of dspace-cocoon-servlet-service-impl to Maven Central
- Once propagated to Maven Central, change the dependency in [Trunk]/dspace-xmlui/dspace-xmlui-wing/pom.xml to point at version 1.0.3 of dspace-cocoon-servlet-service-impl
Version 1.0.3 of dspace-cocoon-servlet-service-impl released to sonatype
dspace-xmlui-wing/pom.xml updated to pick up version 1.0.3 of dspace-cocoon-servlet-service-impl. Committed to trunk revision 6811.
Cheers, Robin.
This problem also seems to extend to all error screens in 1.7.0 XMLUI. Currently the "Invalid Continuation" error screen (e.g. see
DS-613), and general Cocoon Error screens both also return 200 OK instead of 404 Not Found.I'm not sure what could have changed, as the error handling at the bottom of the main sitemap.xmap, specifically says to return a 404 response (see the 'status-code' value below):
http://scm.dspace.org/svn/repo/dspace/trunk/dspace-xmlui/dspace-xmlui-webapp/src/main/webapp/sitemap.xmap
<map:when test="invalid-continuation">
{request:contextPath}<map:generate type="exception"/>
<map:transform src="exception2html.xslt">
<map:parameter name="contextPath" value="
"/>
<map:parameter name="pageTitle" value="Invalid Continuation"/>
</map:transform>
<map:serialize type="xhtml" status-code="404"/>
</map:when>
If anyone has an ideas on this, I'd appreciate suggestions. I'll keep digging around a bit to see what I can figure out.