Details

    • Type: Improvement
    • Status: Open
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: Fedora 4.4.0
    • Fix Version/s: None
    • Component/s: f4-java-client
    • Labels:
      None
    • Environment:
      Fedora 4.4.0, Java 8, MacOS

      Description

      Considering FCREPO-1875 and FCREPO-1901, the FcrepoResponse is responsible for managing the state of the HTTP response object (if FCREPO-1901 is implemented, this is represented as a member variable containing the CloseableHttpResponse, if not, it may be represented as an InputStream to the response body).

      Allowing clients to mutate that state in arbitrary ways (e.g. by setting a different response object, or modifying the status code) makes it more difficult for the FcrepoResponse to manage that state. Ideally, the FcrepoResponse would provide accessors to necessary state, but restrict access to mutating that state.

      One consideration is that methods such as FcrepoResponse#setBody(InputStream) are used throughout the unit tests, so some refactoring may be necessary, or simply reducing the visibility of the mutating methods may be sufficient.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                esm Elliot Metsger
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated: