Uploaded image for project: 'Islandora'
  1. Islandora
  2. ISLANDORA-1413

Video SP uses invalid search to valid selected MP4 encoders

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 7.x-1.5
    • Fix Version/s: 7.x-1.6
    • Component/s: Video Solution Pack
    • Labels:
      None
    • Sprint:
      Islandora 7.x-1.6 Sprint 01

      Description

      Entering "libfaac" as the MP4 encoder on the Video Solution Pack admin page gets me the error.
      "The selected MP4 codec was not found in ffmpeg. Try using aac or enable the desired codec."

      This seems to be because of the grep here:
      https://github.com/Islandora/islandora_solution_pack_video/blame/7.x/includes/admin.form.inc#L131

      It relies on 6 periods before the encoder name. But those periods should/could be characters based on
      Encoders:
      V..... = Video
      A..... = Audio
      S..... = Subtitle
      .F.... = Frame-level multithreading
      ..S... = Slice-level multithreading
      ...X.. = Codec is experimental
      ....B. = Supports draw_horiz_band
      .....D = Supports direct rendering method 1

      So my relevant line for libfaac is
      A..... libfaac libfaac AAC (Advanced Audio Coding) (codec aac)

        Attachments

          Activity

            People

            • Assignee:
              nruest Nick Ruest
              Reporter:
              whikloj Jared Whiklo
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: