Uploaded image for project: 'Islandora'
  1. Islandora
  2. ISLANDORA-1761

Remove the BOM from CSLDateparser.php

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Fix Version/s: 7.x-1.7
    • Component/s: Scholar Module
    • Labels:
      None

      Description

      The first three bytes of CSLDateparser.php (https://github.com/Islandora/islandora_scholar/blob/7.x/modules/citeproc/includes/CSLDateparser.php) are a little-endian byte-order marker. When the file is loaded, this marker is appended to the start of PHP's output buffer.

      This is largely benign for a number of reasons, but we should get rid of it anyway due to some edge cases: most browsers can deal with it, but in cases where we're doing things like dumping JSON or XML, less-than-stellar parsers might get confused and barf.

        Attachments

          Activity

            People

            • Assignee:
              mbagget1 Mark Baggett
              Reporter:
              daitken Daniel Aitken
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: