Uploaded image for project: 'Islandora'
  1. Islandora
  2. ISLANDORA-1859

Inconsistent Solr request handler variable_get

    Details

    • Type: Bug
    • Status: Open
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 7.x-1.10
    • Fix Version/s: 7.x-1.11
    • Component/s: Solr Search
    • Labels:
      None

      Description

      The request handler variable is inconsistent in spots and could cause some problems in the event a FALSE is returned.

      -Use Case-
      Request handler returns a FALSE and behavior breaks.

      -Technical Approach-
      Change how the following areas deal with the default value of the request handler to only set a the qt parameter if it's defined:

      /islandora_ocr/includes/solr.inc:35: 'qt' => (variable_get('islandora_solr_request_handler', 'standard') ? variable_get('islandora_solr_request_handler', 'standard') : ''),
      ./islandora_solr_search/includes/query_processor.inc:80: if (variable_get('islandora_solr_request_handler', '') == 'standard') {
      ./islandora_solr_search/includes/query_processor.inc:195: $request_handler = variable_get('islandora_solr_request_handler', FALSE);

        Attachments

          Activity

            People

            • Assignee:
              nhart Nelson Hart
              Reporter:
              jordandukart Jordan Dukart
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated: