Uploaded image for project: 'Islandora'
  1. Islandora
  2. ISLANDORA-1927

phpcs complains about a non directly sanitized value in a $form array

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 7.x-1.9
    • Component/s: Paged Content
    • Labels:
      None

      Description

      My fault here:
      As required by me
      https://github.com/Islandora/islandora_paged_content/pull/120 removed all sanitizing since the value was previously being passed through t() and other dry cleaning operations.

      But: Drupal Coding Standards enforced by phpcs expected those operations to happen inline, at that particular form array key value, resulting in

      sites/all/modules/islandora_paged_content/includes/manage_pages.inc:
       +598: [critical] Potential problem: FAPI elements '#title' and '#description' only accept filtered text, be sure to use check_plain http://api.drupal.org/api/function/check_plain/(), filter_xss http://api.drupal.org/api/function/filter_xss/() or similar to ensure your $variable is fully sanitized
      

      So i will have to go back to Patrick Dunlavey original proposed code (sorry) to allow Travis to pass. This will required (release times) two pull requests.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              dpinokrayon Diego Pino Navarro
              Reporter:
              dpinokrayon Diego Pino Navarro
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - 1 hour
                  1h
                  Remaining:
                  Remaining Estimate - 1 hour
                  1h
                  Logged:
                  Time Spent - Not Specified
                  Not Specified