Uploaded image for project: 'Islandora'
  1. Islandora
  2. ISLANDORA-1931

Incorrect use of constant in Drush command option

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 7.x-1.9
    • Component/s: Checksum Checker
    • Labels:
      None

      Description

      Marking here as #7.x-1.9RC1 so I can find this later.

      During 7.x-1.9 RC1 VM build I saw some funny messages while enabling islandora_checksum_checker module related to the use of a non-existing constant. Those messages appeared over and over each time other modules were enabled.

      The issues is here
      https://github.com/Islandora/islandora_checksum_checker/blob/7.x/islandora_checksum_checker.drush.inc#L60 and https://github.com/Islandora/islandora_checksum_checker/blob/7.x/islandora_checksum_checker.drush.inc#L65

      Coming from this pull:
      https://github.com/Islandora/islandora_checksum_checker/pull/38

      Even if the Drush docs are not 100% clear about that, I think that "constant required" should be just a "string 'required'" http://docs.drush.org/en/7.x/commands/

      Jonathan Green and Mark Jordan in case you have any suggestions before i fix this.

        Attachments

          Activity

            People

            • Assignee:
              dpinokrayon Diego Pino Navarro
              Reporter:
              dpinokrayon Diego Pino Navarro
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - 1 day
                1d
                Remaining:
                Remaining Estimate - 1 day
                1d
                Logged:
                Time Spent - Not Specified
                Not Specified