Uploaded image for project: 'Islandora'
  1. Islandora
  2. ISLANDORA-1998

Replace datastream link won't show up without view datastream history permission

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 7.x-1.9
    • Fix Version/s: 7.x-1.10
    • Labels:
      None

      Description

      Currently, the Replace datastream link won't show up unless you also have the View Datastream History link. Reported by Alex Kent on the mailing list [1].

      The ISLANDORA_VIEW_DATASTREAM_HISTORY permission is explicitly called within template_preprocess_islandora_default_edit() [2]. Note that the correct permission is then checked within theme_islandora_datastream_replace_link()[3].

      Not sure if intentional. Pinging Jordan Dukart in case he has any insight on this?

      [1] https://groups.google.com/forum/#!topic/islandora/E0q3e-ZiK7Q

      [[2] https://github.com/Islandora/islandora/blob/b014b6285a2919fc73a15bc908b2de1d3c47616d/theme/theme.inc#L67|https://github.com/Islandora/islandora/blob/b014b6285a2919fc73a15bc908b2de1d3c47616d/theme/theme.inc#L67]

      [3] https://github.com/Islandora/islandora/blob/b014b6285a2919fc73a15bc908b2de1d3c47616d/theme/theme.inc#L599 

       

      This might be related to ISLANDORA-1508, which reported a similar convolution of permissions but was never replicated.

        Attachments

          Activity

            People

            • Assignee:
              rosiel Rosie Le Faive
              Reporter:
              rosiel Rosie Le Faive
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: