Uploaded image for project: 'Islandora'
  1. Islandora
  2. ISLANDORA-2009

NewFedoraDatastream checksums are immediately unset after setting

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 7.x-1.9
    • Fix Version/s: 7.x-1.10
    • Component/s: Tuque API
    • Labels:
      None

      Description

      Placing this as 'major' as there is no workaround possible here. This is just a straight-up Tuque bug right down at the bottom.

       

      The error is here

       

      After this specific case, there is no break statement. The switch therefore happily moves on to case 'unset' and immediately unsets whatever checksum was set.

       

      We should:

      • Jam a break in there
      • Write tests for this case. Really, NewDatastreamTest.php should contain more tests, as we have weird use cases
      • Update the tuque docs to say that checksums are mutable. That one's my bad; I always thought they were immutable because setting them never worked because of this

        Attachments

          Activity

            People

            • Assignee:
              daitken Daniel Aitken
              Reporter:
              daitken Daniel Aitken
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: