Uploaded image for project: 'Islandora'
  1. Islandora
  2. ISLANDORA-2029

Openseadragon Default Tile overlap not respected by JS logic

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 7.x-1.10
    • Component/s: OpenSeadragon
    • Labels:
      None

      Description

      At https://github.com/Islandora/islandora_openseadragon/blob/7.x/js/djtilesource.js#L66 the logic that sets the default for the tile overlap defaults to "2". If tile overlap is set to "0", which w the default used previously and the one that gives better results. as

      See Comments from github pull request that introduced this tiny little bug

      Giancarlo reported this

      William Panting confirmed the bug

      Nigel Banks found the error and will make a pull

       Also, de default set to 2 at https://github.com/Islandora/islandora_openseadragon/blob/7.x/islandora_openseadragon.module#L10 could be revisited?

       Best,

      Diego Pino

       

       

        Attachments

          Activity

            People

            • Assignee:
              nigelgbanks Nigel Banks
              Reporter:
              giancarlo.birello Giancarlo
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: