Uploaded image for project: 'Islandora'
  1. Islandora
  2. ISLANDORA-2040

Wrong suggested signature in hook_islandora_derivative implementation

    Details

      Description

      hook_islandora_derivative defined as

      function hook_islandora_derivative(AbstractObject $object = NULL, $ds_modified_params = array()) {

      https://github.com/Islandora/islandora/blob/83a0781e7011f300bbec9cee876b0efaa405e9e2/islandora.api.php#L706

      Defines that Object passed can be optional. All implementations in Islandora Core respect that.
      Pull 126 in
      https://github.com/Islandora/islandora_solution_pack_compound/pull/126#discussion-diff-132515821R292 specifies Abstract Object as required, breaking any implementation, invocation that does not pass an object.

      In specific:
      https://github.com/ryanbrinn/islandora_solution_pack_compound/blob/10a1e7d96c87bfa0a635ed8f14f07dfc2f5b1120/islandora_compound_object.module#L271-L287

      does not make use of an Abstract Object nor requires one in the logic, so can be defaulted to NULL easily or not even needed.

        Attachments

          Activity

            People

            • Assignee:
              dpinokrayon Diego Pino Navarro
              Reporter:
              dpinokrayon Diego Pino Navarro
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: