Uploaded image for project: 'Islandora'
  1. Islandora
  2. ISLANDORA-2044

Wrong response in case MODS does not exists

    Details

    • Type: Bug
    • Status: Open
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 7.x-1.9, 7.x-1.10
    • Fix Version/s: 7.x-1.11
    • Component/s: MARCXML
    • Labels:
      None

      Description

      There seems to be an issue related to reusing blindly results from XSLT transformations as input for other XLST transformations.
      e.g[ Function that transforms MODS to MARCXML|https://github.com/Islandora/islandora_marcxml/blob/7.x/includes/utilities.inc#L39-L48] returns drupal_not_found() in case no MODS datastreams is present and probably nothing if the transformation fails.. silently fails because of the warning suppressing argument at https://github.com/Islandora/islandora_marcxml/blob/7.x/includes/utilities.inc#L27

      That same function is used to as input for the HTML generating XSLT transformation. There are two issues there:
      1. Calling a new XSTL with empty input is bad practice.
      2. Calling a new XSTL with a Drupal not found response used as input even weirder because that is no input at all, just a circuit breaker calling. See https://api.drupal.org/api/drupal/includes%21common.inc/function/drupal_not_found/7.x
      https://github.com/Islandora/islandora_marcxml/blob/7.x/includes/utilities.inc#L63

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              dpinokrayon Diego Pino Navarro
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated: