Uploaded image for project: 'Islandora'
  1. Islandora
  2. ISLANDORA-2047

Adore Djatoka URL validation logic defaults to locahost/ making deployment on our vagrant fail

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 7.x-1.10
    • Component/s: OpenSeadragon
    • Labels:
      None

      Description

      In Openseadragon´s admin form,

      function islandora_openseadragon_admin_form_djatoka_access_message($path) {
      $url = url("http://localhost/{$path}", array(

      and function islandora_openseadragon_djatoka_url_validate()

      assume that the Adore Djatoka Path passed need to be resolvable on localhost (port 80). Even if that is the most common scenario when using proxy pass, our vagrant machines (islandora dev and release ones) run on port 8000. If you upgraded from the previous openseadragon and have not yet used the admin form, previous path will stay and openseadragon should continue to work, but if you go to admin form, new setting won´t stick because the form would not be able to validate and you will get a wrong path message.

      Solution is simple.
      remove localhost at all. If passing the path alone, since URL is being set via "absolute" flag, it will expand to current drupal base URL, if passing full URL (with protocol and/or port) it will be handled as such.

        Attachments

          Activity

            People

            • Assignee:
              dpinokrayon Diego Pino Navarro
              Reporter:
              dpinokrayon Diego Pino Navarro
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: