Uploaded image for project: 'Islandora'
  1. Islandora
  2. ISLANDORA-2121

Default variables for all variable_get() calls

    Details

      Description

      All our calls to variable_get() should include a default value. A few cases where it didn't slipped by:


      $ ack 'variable_get\([^,]*\)'

      islandora_badges/modules/islandora_wos/islandora_wos.module
      126: $badge_type = variable_get('islandora_wos_badgetype');

      islandora_bagit/islandora_bagit.module
      446: if (variable_get('islandora_file_default_scheme') == 'private') {
      447: $drupal_files_path = variable_get('islandora_file_private_path');
      882: if (variable_get('islandora_file_default_scheme') == 'private') {
      883: $drupal_files_path = variable_get('islandora_file_private_path');

      islandora_ocr/islandora_ocr.install
      39: $book = variable_get('islandora_book_ingest_derivatives');
      45: $newspaper = variable_get('islandora_newspaper_ingest_derivatives');

      islandora_solr_search/islandora_solr.install
      177: if (strpos($term, variable_get('islandora_solr_snippet_field')) !== FALSE) {

      islandora_solution_pack_collection/islandora_basic_collection.install
      46: $old_var = variable_get('islandora_basic_collection_page_size');

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              rosiel Rosie Le Faive
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated: