Uploaded image for project: 'Islandora'
  1. Islandora
  2. ISLANDORA-542

convert syntax for TN missing quotes large_image.inc

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:
      None

      Description

      line 58 exec("convert \"{$file}\"[0] -thumbnail x2000 -thumbnail x450 -resize '450x<' -resize 50% -fuzz 1% -trim +repage -gravity center -crop 200x200+0+0 +repage -format jpg -quality 100 $file-tn.jpg", $output, $returnValue);

      variable $file-tn.jpg should be \"$file-tn.jpg\" just as it is in line 51 for the medium jpg

      The existing format will work in most instances but some nastier file names break the current format.

      This may of course be current in other solution packs where convert is creating a TN.

      This also highlights a great need to sanitize filenames where possible or at least notifying the user when a naming convention breaks.

      Example of nastiness.... #61 - (11) - I.H.tif

      adding the quotes is extremely minor, checking over all longer, actually santizing filenames further may be a bigger issue requiring more thought

        Attachments

          Activity

            People

            • Assignee:
              astanley@upei.ca Alan Stanley
              Reporter:
              plux Peter Lux
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: